Add option to only show failures on test reports#1563
Open
stackoverflow wants to merge 2 commits intoapple:mainfrom
Open
Add option to only show failures on test reports#1563stackoverflow wants to merge 2 commits intoapple:mainfrom
stackoverflow wants to merge 2 commits intoapple:mainfrom
Conversation
HT154
approved these changes
Apr 28, 2026
Contributor
HT154
left a comment
HT154
left a comment
There was a problem hiding this comment.
Just a couple nits, approving to unblock
Comment on lines
96
to
106
| private void reportResults(TestSectionResults section, AnsiStringBuilder builder) { | ||
| if (!section.results().isEmpty()) { | ||
| var results = | ||
| showOnlyFailed | ||
| ? section.results().stream().filter(TestResult::isFailure).toList() | ||
| : section.results(); | ||
| if (!results.isEmpty()) { | ||
| builder.append(" ").append(section.name()).append('\n'); | ||
| StringUtils.joinToStringBuilder( | ||
| builder, section.results(), "\n", res -> reportResult(res, builder)); | ||
| StringUtils.joinToStringBuilder(builder, results, "\n", res -> reportResult(res, builder)); | ||
| builder.append('\n'); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
(Not a blocker) This result in output that includes the test module name but no further details:
❯ ../pkl/pkl-cli/build/executable/jpkl test --project-dir packages/com.github.dependabot --show-only-failed
module com.github.dependabot.tests.Dependabot
module com.github.dependabot.tests.examples
100.0% tests pass [2 passed], 100.0% asserts pass [2 passed]Is this really desired? It seems like it might be nice to either omit module names with only passing tests or indicate somehow that all tests in the module passed.
Contributor
Author
There was a problem hiding this comment.
Is this really desired?
Yes. The idea is to show all modules being tests. I think hiding the module names might be confusing.
We could show the green passed checkmark after the tests if we are hiding all the results and there's no failure. Open to ideas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.